refactor mu_nu in hodge.py #6650
Conversation
| """ | ||
| Compute ``mu`` and ``nu`` given Hodge numbers and signature. | ||
| tmp = [[(q(p) - p) / 2.] * int(hodge_index(p)) for p in range((motivic_weight + 1) // 2)] |
There was a problem hiding this comment.
I don't know how this code is supposed to be used, but (motivic_weight - 2 * p) / 2 won't have the same type as (motivic_weight - 2 * p) / 2. Did you change this on purpose?
There was a problem hiding this comment.
I made sure that everything is either a sage integer of a sage rational.
There was a problem hiding this comment.
The problem is that rational numbers and float don't display the same, and I'm not sure where this is used. Can you track down what webpages these are displayed on, and see if they're currently shown as floats?
There was a problem hiding this comment.
This issue needs to be clarified before we can merge this PR. I'm going to close for now, but am happy to reopen if you address this.
| self.check_args("/Motive/Hypergeometric/Q/A6.4.4.3_B12.2.2.2.1", "1 + 6 T - 45 p T^{2} - 2130 p^{2} T^{3} + 268 p^{4} T^{4} - 2130 p^{6} T^{5} - 45 p^{9} T^{6} + 6 p^{12} T^{7} + p^{16} T^{8}") | ||
|
|
||
| ### motive pages | ||
| # ## motive pages |
There was a problem hiding this comment.
Why are you inserting spaces in these kinds of comments? I find # ## motive pages a lot less appealing than ### motive pages.
There was a problem hiding this comment.
This is a codestyle suggestion by pycodestyle. Very low priority, of course.
2 participants
and a few other minor details, mostly in hypergm